Conversation
67e1bcb to
48bfa66
Compare
bdfa553 to
edc19ae
Compare
js-murph
reviewed
Jan 28, 2026
| GIT_COMMIT := `git rev-parse HEAD 2>/dev/null || echo "unknown"` | ||
| TAG := `git rev-parse --short HEAD 2>/dev/null || echo "dev"` | ||
| RELEASE := "dist" | ||
| REGISTRY := env_var_or_default("REGISTRY", "268271485387.dkr.ecr.us-west-2.amazonaws.com") |
Contributor
There was a problem hiding this comment.
Out of curiousity where is this? Is this an account for OSS artifacts?
Contributor
There was a problem hiding this comment.
If this is internal, I think we should consider using ghcr or docker hub and then republishing internally via another mechanism
alecthomas
reviewed
Jan 28, 2026
b6b6791 to
51d212c
Compare
nssherpa
commented
Jan 28, 2026
js-murph
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Images are pushed to blox ecr account for now, repository.
Testing
Docker image is being built and pushed to ghcr.io, tested via this branch https://github.com/block/cachew/pkgs/container/cachew
Downloaded the test image ran and tested with cachew cli.
docker pull ghcr.io/block/cachew:pr-63